AARoads Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

Thanks to everyone for the feedback on what errors you encountered at https://www.aaroads.com/forum/index.php?topic=33904.0
Corrected several already and appreciate your patience as we work through the rest.

Author Topic: Highway Data Discussion (CHM/TravelMapping)  (Read 119589 times)

sammi

  • *
  • Offline Offline

  • Posts: 1147
  • Software Developer, Sign Designer

  • Age: 26
  • Location: Toronto, ON / Baguio, Phils.
  • Last Login: December 27, 2022, 11:52:09 PM
    • SammDOT (under construction)
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #50 on: June 25, 2015, 09:54:56 PM »

I'm not seeing any text in the top left where it would list the waypoints.  No idea why.  Using Firefox 39 Beta.

For reference, this is what it looks like on my browser (Chrome 43):



Can I see a screenshot, so I could figure out what the problem is?
Logged

rickmastfan67

  • The Invisible One
  • *
  • *
  • Offline Offline

  • Posts: 3222
  • I want I-67 in PA!!!!

  • Age: 39
  • Location: Pittsburgh, Pa, USA
  • Last Login: March 16, 2024, 01:05:30 AM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #51 on: June 25, 2015, 10:14:54 PM »

I'm not seeing any text in the top left where it would list the waypoints.  No idea why.  Using Firefox 39 Beta.

For reference, this is what it looks like on my browser (Chrome 43):



Can I see a screenshot, so I could figure out what the problem is?

Here you go:


I even tried to load it in safe mode and still didn't have any text in the top left load.

Dr Frankenstein

  • *
  • Offline Offline

  • Posts: 1491
  • Canada Freezes Before Your Roads.

  • Age: 33
  • Location: LeMoyne, QC
  • Last Login: September 01, 2022, 10:24:33 PM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #52 on: June 26, 2015, 09:09:38 AM »

QC:
ISTR that Oscar has kept his eyes on a number of changes that need to be made from the versions currently in the HB, and may have already made the edits to his local files. I'd offer to take QC (because Canada yadda yadda GISplunge), but offer first dibs to Oscar.
Carl, any objections?

Sure. I'll be sure to raise a flag myself if anything changes in the autoroute system over here.

I have a prototype waypoint editor ready! :sombrero:

    http://travelmapping.sammdot.ca/wptedit.html

Awesome! I can't test it myself yet because my work computer has IE 9 and Fx 15 (both obsolete), but it's looking great!
« Last Edit: June 26, 2015, 09:11:52 AM by Dr Frankenstein »
Logged

SSOWorld

  • 'Sconsin
  • *
  • *
  • Offline Offline

  • Posts: 4227
  • Interstate <Make up your mind!>

  • Location: MAH House!
  • Last Login: March 18, 2024, 07:24:47 PM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #53 on: June 26, 2015, 09:20:23 AM »

The following regions are up for grabs wrt maintanance due to Tim's absence (some of these are me making room for Tim's European systems):
- Arizona
- DC
- Delaware
- Idaho
- Kentucky
- Lousiana
- Maryland
- New Jersey
- Pennsylvania
- Quebec
Should Oscar not want them I can volunteer to take on a couple of these.  Arizona and New Jersey come to mind but I'll take on a couple more if help is needed.

I'd love to take up Wisconsin, but since it's been claimed and well maintained I won't speak up, thanks Jeff M.  :D

On that note - newcomers should be made aware of what the guidelines for placing a route on the map are such as waypoint spacing, source validation, etc.
Logged
Scott O.

Not all who wander are lost...
Ah, the open skies, wind at my back, warm sun on my... wait, where the hell am I?!
As a matter of fact, I do own the road.
Raise your what?

Wisconsin - out-multiplexing your state since 1918.

sammi

  • *
  • Offline Offline

  • Posts: 1147
  • Software Developer, Sign Designer

  • Age: 26
  • Location: Toronto, ON / Baguio, Phils.
  • Last Login: December 27, 2022, 11:52:09 PM
    • SammDOT (under construction)
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #54 on: June 26, 2015, 09:33:09 AM »



As it turns out I used Node.innerText, which is a nonstandard feature (that I thought was standard) that doesn't exist in Firefox. I tested it in Firefox 38, so it should work now.
Logged

Jim

  • *
  • Offline Offline

  • Posts: 6731
  • Check out https://travelmapping.net

  • Location: Amsterdam, NY
  • Last Login: Today at 05:41:43 AM
    • Travel and Other Pictures
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #55 on: June 26, 2015, 10:10:31 AM »

This is excellent.  I hope that once sammi's new wpt editor is far enough along, we can convert all "chm_final" data to the new format (with a corresponding mechanism to allow all those who have updated/new wpts on their own systems to be converted easily).  I hope many of the long-time CHM route plotters/maintainers will try it out and make suggestions so we have something at least as functional and useful as Tim's old editor.
Logged
Photos I post are my own unless otherwise noted.
Signs: https://www.teresco.org/pics/signs/
Travel Mapping: https://travelmapping.net/user/?u=terescoj
Counties: http://www.mob-rule.com/user/terescoj
Twitter @JimTeresco (roads, travel, skiing, weather, sports)

Jim

  • *
  • Offline Offline

  • Posts: 6731
  • Check out https://travelmapping.net

  • Location: Amsterdam, NY
  • Last Login: Today at 05:41:43 AM
    • Travel and Other Pictures
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #56 on: June 26, 2015, 10:22:30 AM »

I think it would be useful to have a list of essential features for the editor to help sammi out with design and implementation.  Here are some to start:

- easy adding, removing, renaming, reordering of points, either through the map or by editing the text box

- maintain both visible and hidden waypoints, multiple names for waypoints

- report errors that will flag datacheck problems right in the editor

- "red line" bars or some better mechanism to help see if the actual route stays within the appropriate tolerance of the plotted route's segments

- I'd like to see support added for comments - lines starting with #, which I believe is not a valid label character
Logged
Photos I post are my own unless otherwise noted.
Signs: https://www.teresco.org/pics/signs/
Travel Mapping: https://travelmapping.net/user/?u=terescoj
Counties: http://www.mob-rule.com/user/terescoj
Twitter @JimTeresco (roads, travel, skiing, weather, sports)

sammi

  • *
  • Offline Offline

  • Posts: 1147
  • Software Developer, Sign Designer

  • Age: 26
  • Location: Toronto, ON / Baguio, Phils.
  • Last Login: December 27, 2022, 11:52:09 PM
    • SammDOT (under construction)
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #57 on: June 26, 2015, 11:00:20 AM »

maintain both visible and hidden waypoints, multiple names for waypoints

adding
✓ You can use the Add Waypoint button or double-click on the map to add a waypoint. Add Waypoint will add it to the center of the map, double clicking will add it where you clicked.
removing

renaming
, but only partially. Right now it can edit the main label, but none of the other labels.
reordering of points
I'm thinking of having a drag-and-drop system to rearrange the points, instead of having to move up and down so many times. I'm not sure yet how I would implement that though.

report errors that will flag datacheck problems right in the editor
I have the list of possible errors that you linked last night. I'll write an error checking thing after I get the label thing down.

"red line" bars or some better mechanism to help see if the actual route stays within the appropriate tolerance of the plotted route's segments
So that's what that was for.

comments
Does that mean I have to export comments to the output file too?
« Last Edit: June 26, 2015, 01:46:46 PM by sammi »
Logged

yakra

  • *
  • Offline Offline

  • Posts: 1320
  • Location: Area Code 207, bub!
  • Last Login: February 13, 2024, 06:39:12 PM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #58 on: June 26, 2015, 11:54:11 AM »

I see the text listing of waypoint labels, but the map pane is completely blank white. Firefox 20.0.

I think for my part, I'll keep on using Tim's editor. I've downloaded the HTML and JS files. I may end up making some edits to it to work with the new format, and possibly flag some of the possible errors it doesn't report yet.
...If I decide it's worth the trouble.
Which, who knows, I might. While writing an old->new WPT file format converter would be trivial using the C++ code I already have for the listfile mapper, GISplunge, and the like, it's just be a PITA to have to run every completed file thru a converter every time I make an edit.
Logged
"Officer, I'm always careful to drive the speed limit no matter where I am and that's what I was doin'." Said "No, you weren't," she said, "Yes, I was." He said, "Madam, I just clocked you at 22 MPH," and she said "That's the speed limit," he said "No ma'am, that's the route numbah!"  - Gary Crocker

yakra

  • *
  • Offline Offline

  • Posts: 1320
  • Location: Area Code 207, bub!
  • Last Login: February 13, 2024, 06:39:12 PM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #59 on: June 26, 2015, 11:56:09 AM »

As for comment support, I'm lukewarm on that. Seems kinda mission creep-y. I like the original (Tim era) idea of keeping the route files (and lists n'at) down to just the necessary bare-bones.
Logged
"Officer, I'm always careful to drive the speed limit no matter where I am and that's what I was doin'." Said "No, you weren't," she said, "Yes, I was." He said, "Madam, I just clocked you at 22 MPH," and she said "That's the speed limit," he said "No ma'am, that's the route numbah!"  - Gary Crocker

sammi

  • *
  • Offline Offline

  • Posts: 1147
  • Software Developer, Sign Designer

  • Age: 26
  • Location: Toronto, ON / Baguio, Phils.
  • Last Login: December 27, 2022, 11:52:09 PM
    • SammDOT (under construction)
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #60 on: June 26, 2015, 12:14:59 PM »

I see the text listing of waypoint labels, but the map pane is completely blank white. Firefox 20.0.

Firefox 20?! :ded: The browser support tables I'm using don't even have it listed as a version anymore. Also if the map isn't loading then that's an issue with the Google Maps API and not my code.
Logged

sipes23

  • *
  • Offline Offline

  • Posts: 181
  • Location: Where US 20 leaves I-25.
  • Last Login: December 12, 2021, 03:11:51 AM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #61 on: June 26, 2015, 01:27:55 PM »

Works pretty nicely. I did WY77 without too much trouble. I could probably do a whole bunch more.
Logged

Jim

  • *
  • Offline Offline

  • Posts: 6731
  • Check out https://travelmapping.net

  • Location: Amsterdam, NY
  • Last Login: Today at 05:41:43 AM
    • Travel and Other Pictures
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #62 on: June 26, 2015, 04:06:57 PM »

As for comment support, I'm lukewarm on that. Seems kinda mission creep-y. I like the original (Tim era) idea of keeping the route files (and lists n'at) down to just the necessary bare-bones.

I support "keep it simple" but I do think this is a minor change that is easy to account for in parsing code [ if line.startswith('#') ]  and would let us note right in the route files if there was a good reason to do something unusual like points moved a bit to break false concurrencies, labels chosen to avoid collisions with others in the file, etc.
Logged
Photos I post are my own unless otherwise noted.
Signs: https://www.teresco.org/pics/signs/
Travel Mapping: https://travelmapping.net/user/?u=terescoj
Counties: http://www.mob-rule.com/user/terescoj
Twitter @JimTeresco (roads, travel, skiing, weather, sports)

Jim

  • *
  • Offline Offline

  • Posts: 6731
  • Check out https://travelmapping.net

  • Location: Amsterdam, NY
  • Last Login: Today at 05:41:43 AM
    • Travel and Other Pictures
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #63 on: June 26, 2015, 04:10:56 PM »

Does that mean I have to export comments to the output file too?

I'd say as long as it just kept them it would be enough for me.  But as we've not even agreed that comments are worth the trouble, I'd say don't worry about that just yet.  Progress continues to look excellent, by the way!
Logged
Photos I post are my own unless otherwise noted.
Signs: https://www.teresco.org/pics/signs/
Travel Mapping: https://travelmapping.net/user/?u=terescoj
Counties: http://www.mob-rule.com/user/terescoj
Twitter @JimTeresco (roads, travel, skiing, weather, sports)

Jim

  • *
  • Offline Offline

  • Posts: 6731
  • Check out https://travelmapping.net

  • Location: Amsterdam, NY
  • Last Login: Today at 05:41:43 AM
    • Travel and Other Pictures
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #64 on: June 26, 2015, 04:46:45 PM »

Should we go to the proposed new format, the following Python code that can do the conversion is being added to the GitHub repository TravelMapping/HighwayData under wptconverter/convert.py

It uses .wpt2 as the new extension for lack of a better idea - I make no suggestion that that's what we should use.

Code: [Select]
#!/usr/bin/env python3
# Travel Mapping Project, Jim Teresco, 2015
"""Python code to read an old-format .wpt file and
write a new format .wpt2 file.

The old format consists of lines such as

PA/NY +0 http://www.openstreetmap.org/?lat=42.252473&lon=-79.761515

which would convert to

42.252473 79.761515 PA/NY +0

(c) 2015, Jim Teresco
"""

import argparse

# argument parsing
parser = argparse.ArgumentParser(description="Convert wpt to wpt2 file.")
parser.add_argument("fileroot", help="root file name to be converted (fileroot.wpt becomes fileroot.wpt2)")
args = parser.parse_args()
outfile = open(args.fileroot+'.wpt2','wt')
with open(args.fileroot+'.wpt','rt') as infile:
    lines = infile.readlines()

for line in lines:
    parts = line.split()
    url_parts = parts[-1].split('=')
    lat_string = url_parts[1].split("&")[0] # chop off "&lon"
    lng_string = url_parts[2].split("&")[0] # chop off possible "&zoom"
    outfile.write(lat_string + ' ' + lng_string + ' ' + parts[0])
    for p in parts[1:-1]:
        outfile.write(' ' + p)
    outfile.write('\n')

outfile.close()
Logged
Photos I post are my own unless otherwise noted.
Signs: https://www.teresco.org/pics/signs/
Travel Mapping: https://travelmapping.net/user/?u=terescoj
Counties: http://www.mob-rule.com/user/terescoj
Twitter @JimTeresco (roads, travel, skiing, weather, sports)

rickmastfan67

  • The Invisible One
  • *
  • *
  • Offline Offline

  • Posts: 3222
  • I want I-67 in PA!!!!

  • Age: 39
  • Location: Pittsburgh, Pa, USA
  • Last Login: March 16, 2024, 01:05:30 AM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #65 on: June 26, 2015, 08:27:58 PM »



As it turns out I used Node.innerText, which is a nonstandard feature (that I thought was standard) that doesn't exist in Firefox. I tested it in Firefox 38, so it should work now.

Working fine with FF 39. :)

One suggestion thought, I'd make the 'labels' on the left smaller.  That way, we can get more labels seen at one time for the longer routes.

I see the text listing of waypoint labels, but the map pane is completely blank white. Firefox 20.0.

Dude!  At least download the poratble version to use for the new editor. ;)

sammi

  • *
  • Offline Offline

  • Posts: 1147
  • Software Developer, Sign Designer

  • Age: 26
  • Location: Toronto, ON / Baguio, Phils.
  • Last Login: December 27, 2022, 11:52:09 PM
    • SammDOT (under construction)
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #66 on: June 27, 2015, 11:44:42 AM »

Should we go to the proposed new format, the following Python code that can do the conversion is being added to the GitHub repository TravelMapping/HighwayData under wptconverter/convert.py

It uses .wpt2 as the new extension for lack of a better idea - I make no suggestion that that's what we should use.

The new waypoint editor now also supports importing the old CHM format. :) It can be selected as an option when importing waypoint data. (It still only exports to the new format though.) Also, I changed it to use the .wpt2 extension, so that's pretty much official now.
Logged

yakra

  • *
  • Offline Offline

  • Posts: 1320
  • Location: Area Code 207, bub!
  • Last Login: February 13, 2024, 06:39:12 PM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #67 on: June 27, 2015, 12:31:45 PM »

Dude!  At least download the poratble version to use for the new editor. ;)
Not sure what you mean here.
Logged
"Officer, I'm always careful to drive the speed limit no matter where I am and that's what I was doin'." Said "No, you weren't," she said, "Yes, I was." He said, "Madam, I just clocked you at 22 MPH," and she said "That's the speed limit," he said "No ma'am, that's the route numbah!"  - Gary Crocker

sammi

  • *
  • Offline Offline

  • Posts: 1147
  • Software Developer, Sign Designer

  • Age: 26
  • Location: Toronto, ON / Baguio, Phils.
  • Last Login: December 27, 2022, 11:52:09 PM
    • SammDOT (under construction)
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #68 on: June 27, 2015, 02:09:32 PM »

Error checking is now implemented to some extent. Right now it only checks for errors type 1, 2, 3, 5, 6, 7, 10 and 18, because those are the easiest to check for. :) It can also differentiate between possible errors and true errors.

A possible error would be outlined in red, like so:


A true error would also be highlighted in red:


True errors would now also prevent the waypoint data from being exported; possible errors would not.
Logged

rickmastfan67

  • The Invisible One
  • *
  • *
  • Offline Offline

  • Posts: 3222
  • I want I-67 in PA!!!!

  • Age: 39
  • Location: Pittsburgh, Pa, USA
  • Last Login: March 16, 2024, 01:05:30 AM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #69 on: June 27, 2015, 07:10:32 PM »

Dude!  At least download the poratble version to use for the new editor. ;)
Not sure what you mean here.

There are portable versions of Firefox.

english si

  • *
  • Offline Offline

  • Posts: 3637
  • Age: 37
  • Location: Buckinghamshire, England
  • Last Login: July 02, 2022, 05:33:16 AM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #70 on: June 28, 2015, 10:54:55 AM »

The new waypoint editor now also supports importing the old CHM format. :) It can be selected as an option when importing waypoint data. (It still only exports to the new format though.) Also, I changed it to use the .wpt2 extension, so that's pretty much official now.
Excellent.

A big issue with the editor (and the browser) at the moment is that it only has Google Maps. OSM data in some form is a must for copyright reasons creating the route (OSM data has a much less restrictive licence than Google data). Other maps are bonuses.
Logged

sammi

  • *
  • Offline Offline

  • Posts: 1147
  • Software Developer, Sign Designer

  • Age: 26
  • Location: Toronto, ON / Baguio, Phils.
  • Last Login: December 27, 2022, 11:52:09 PM
    • SammDOT (under construction)
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #71 on: June 28, 2015, 11:40:09 AM »

A big issue with the editor (and the browser) at the moment is that it only has Google Maps. OSM data in some form is a must for copyright reasons creating the route (OSM data has a much less restrictive licence than Google data). Other maps are bonuses.

Hmm, that was easy. OSM and MapQuest Open (both road and satellite) are now on the map.

I'm somewhat disappointed that MapQuest satellite lacks any sort of large scale data past a few km from the border. :/

Logged

Eth

  • *
  • Offline Offline

  • Posts: 2837
  • Age: 37
  • Location: Georgia
  • Last Login: March 18, 2024, 03:27:18 PM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #72 on: June 28, 2015, 03:18:54 PM »

This looks great!

I've been playing around a little with it today, and I did find one issue: if you reorder waypoints and then go back and try to change the label on one of them, sometimes it changes the label for a different waypoint instead. Example:

- Create waypoint 1
- Create waypoint 2
- Create waypoint 4
- Create waypoint 3 (which you accidentally skipped)
- Create waypoint 5
- Reorder waypoints, putting 3 before 4
- Try to change waypoint 3's label to 3A. Result: Waypoint 4's label changes to 3A.

It seems to be getting the instruction "relabel the 4th (by time of creation) waypoint" and interpreting it as "relabel the 4th waypoint in the list". Or vice versa.
Logged

rickmastfan67

  • The Invisible One
  • *
  • *
  • Offline Offline

  • Posts: 3222
  • I want I-67 in PA!!!!

  • Age: 39
  • Location: Pittsburgh, Pa, USA
  • Last Login: March 16, 2024, 01:05:30 AM
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #73 on: June 28, 2015, 10:12:27 PM »

I'm somewhat disappointed that MapQuest satellite lacks any sort of large scale data past a few km from the border. :/

That's because it's mostly NAIP imagery, and thus, US only.

Hmm, that was easy. OSM and MapQuest Open (both road and satellite) are now on the map.

Also, with the MapQuest Open maps, you need to include the 'MapQuest' icon, just like they do @ OSM.  Also, you need to add direct links to the copyrights like they do on OSM for both.  Just wanting to avoid any future e-mails for you saying that the page is against the license by not linking/showing proper copyright images. ;)
« Last Edit: June 28, 2015, 10:18:15 PM by rickmastfan67 »
Logged

Jim

  • *
  • Offline Offline

  • Posts: 6731
  • Check out https://travelmapping.net

  • Location: Amsterdam, NY
  • Last Login: Today at 05:41:43 AM
    • Travel and Other Pictures
Re: Highway Data Discussion (CHM/TravelMapping)
« Reply #74 on: June 29, 2015, 09:49:38 AM »

Just wanting to avoid any future e-mails for you saying that the page is against the license by not linking/showing proper copyright images. ;)

This reminds me of another issue we should think about before people start editing and drafting new highway data.  I think it's important that we keep the list of sources accurate, and that one or two people should take primary responsibility for that.  I know CHM had this information in a spreadsheet, and that should be our starting point if anyone has a copy or a way to get it.  I don't see it in the data folder, only in web form at http://cmap.m-plex.com/docs/sources.php.
Logged
Photos I post are my own unless otherwise noted.
Signs: https://www.teresco.org/pics/signs/
Travel Mapping: https://travelmapping.net/user/?u=terescoj
Counties: http://www.mob-rule.com/user/terescoj
Twitter @JimTeresco (roads, travel, skiing, weather, sports)

 


Opinions expressed here on belong solely to the poster and do not represent or reflect the opinions or beliefs of AARoads, its creators and/or associates.