NEW features

[vdeane]

I've also noticed that the alerts menu doesn't work - I have to middle-click it to open the main alerts page.

[kphoger]

1. <hr> and <br> with square brackets used to add a horizontal line. Now, they add extra space, but no line is visible.

Testing
this
out
now

[hotdogPi]

Attempting to search, unless it succeeds, results in being locked out (pages refuse to load) for about a minute.

[hotdogPi]

Looking at the code:

https://github.com/SimpleMachines/SMF/blob/release-3.0/Sources/Actions/Search2.php lines 263-271; sapi.php (https://github.com/SimpleMachines/SMF/blob/release-3.0/Sources/Sapi.php) determines the maximum memory allowed

Code (php) Select Expand

/**
* Aborts search if the load average is too high right now.
*/
protected function checkLoadAverage(): void
{
if (Sapi::isOverloaded(Config::$modSettings['loadavg_search'] ?? null)) {
ErrorHandler::fatalLang('loadavg_search_disabled', false);
}
}
same page, lines 510-518

Code (php) Select Expand

// How many results will the user be able to see?
$this->num_results = !empty($_SESSION['search_cache']['num_results']) ? $_SESSION['search_cache']['num_results'] : SearchResult::getNumResults();

// If there are no results that means the things in the cache got deleted, so pretend we have no topics anymore.
if ($this->num_results == 0) {
SearchApi::$loadedApi->results = [];

return;
}
https://github.com/SimpleMachines/SMF/blob/release-3.0/Sources/Search/SearchApi.php lines 1063-1070

Code (php) Select Expand

// Searching a specific topic?
if (!empty($_REQUEST['topic']) || (!empty($_REQUEST['search_selection']) && $_REQUEST['search_selection'] == 'topic')) {
$this->params['topic'] = empty($_REQUEST['search_selection']) ? (int) $_REQUEST['topic'] : (isset($_REQUEST['sd_topic']) ? (int) $_REQUEST['sd_topic'] : '');

$this->params['show_complete'] = true;
} elseif (!empty($this->params['topic'])) {
$this->params['topic'] = (int) $this->params['topic'];
}
The first code block could be used for fixing search in general, while the second and third could be used for fixing thread search. If thread search is fixed but not overall, it will work, as searching right now if the parameters are highly specific. (Trying a thread search right now completes with 0 results rather than refusing to load like a generic search does.)

[hotdogPi]

Thread search is back!

[Roadgeekteen]

Thread search is back!

Let's go! No more Google search and hopefully no more me posting duplicate topics (I'll try my best...)